Matthias Clasen [Wed, 8 Jun 2016 03:04:40 +0000 (23:04 -0400)]
scale, spinbutton: Avoid -0.0
This is a very longstanding bug; time to finally put it to rest.
https://bugzilla.gnome.org/show_bug.cgi?id=118959
Matthias Clasen [Wed, 8 Jun 2016 01:28:44 +0000 (21:28 -0400)]
Ensure that GtkRange allocates enough space for the value
This is a long-standing problem of GtkScale.
https://bugzilla.gnome.org/show_bug.cgi?id=766372
https://bugzilla.gnome.org/show_bug.cgi?id=578626
https://bugzilla.gnome.org/show_bug.cgi?id=79229
Matthias Clasen [Tue, 7 Jun 2016 20:35:06 +0000 (16:35 -0400)]
Fix preconditions in set_max_content_size setters
We must allow resetting the properties to -1.
Benjamin Otte [Tue, 7 Jun 2016 14:08:52 +0000 (16:08 +0200)]
widget: Add classes to widget path even if no style context exists yet
This removes leftover code from when classes where added to the style
context.
Now that they get added directly to css nodes, the classes can exist
without a style context.
https://bugzilla.gnome.org/show_bug.cgi?id=767312
Carlos Garnacho [Mon, 6 Jun 2016 22:27:19 +0000 (00:27 +0200)]
searchenginetracker: Fix prefix searches
With the FTS5 query syntax, when using quotes to delimit the search phrase
the '*' token must happen after the quote, or will otherwise be considered
a character to match, go through the tokenizer, and end up ignored in
result.
Matthias Clasen [Mon, 6 Jun 2016 18:29:27 +0000 (14:29 -0400)]
Revert "scrolledwindow: Bug 766569 - Report child natural size unconditionally"
This reverts commit
0943c9f6b2c3ad5827ae5d8f3742f75e72782e41.
The commit caused unexpected breakage in gtk3-widget-factory,
and also broke the just-added max-content-size properties.
Matthias Clasen [Mon, 6 Jun 2016 18:33:25 +0000 (14:33 -0400)]
widget-factory: Use max-content-size in a popover
This gives a nice example of these properties in action,
in the "Open" popover on page 3.
Tristan Van Berkom [Mon, 6 Jun 2016 02:55:44 +0000 (11:55 +0900)]
scrolledwindow: Bug 767238 - Fixing up for max content sizes
Needed to adjust this again after applying commit
4e5ecb7
for bug 742281. Now that we also have max content size properties,
pushed the addition of possible scrollbar sizes to after the
clause which clamps the child request size into min/max content
sizes.
Phillip Wood [Mon, 25 Apr 2016 12:16:21 +0000 (13:16 +0100)]
Fix hiding popover when focus moves outside
Commit
a01fe14 changed the behaviour of popovers when the focus leaves
them to stop child popovers being hidden when the focus leaves their
parent. However they are now a bit too reluctant to hide - if the
focus passes to an unrelated popover the first popover is not
hidden. Also if the focus passes to another widget that does not
perform a gtk grab then the popover isn't hidden until the user
presses a non-movement key or clicks outside the popover.
The solution is to go back to checking if the focused widget is a
descendant of the popover, but to include popovers and their related
widgets in the ancestry chain.
https://bugzilla.gnome.org/show_bug.cgi?id=765595
Tristan Van Berkom [Sat, 4 Jun 2016 11:57:23 +0000 (20:57 +0900)]
scrolledwindow: Bug 766569 - Report child natural size unconditionally
This patch causes the scrolled window default behavior to change in
such a way that the natural size request of the child is unconditionally
reported, which probably should have been the case since day 1.
This should not cause significant fallout since a scrolled window is
normally used to expand/fill, eating up remaining space for scrollable
content - it will however cause the scrolled window to compete for
additional space with siblings, proportionally to the size of the
scrolled window's content.
Matthias Clasen [Mon, 6 Jun 2016 02:20:38 +0000 (22:20 -0400)]
treeview: fix an off-by-one error
gtk_tree_view_get_path_at_pos() mistakenly identifies the first
pixel of all but the first column in a tree view as belonging to
the previous column.
https://bugzilla.gnome.org/show_bug.cgi?id=708148
Christian Dywan [Tue, 14 Oct 2008 12:33:00 +0000 (12:33 +0000)]
object test: Also test object type properties
Old patch found in bugzilla, it still applies and doesn't
cause the test to fail.
https://bugzilla.gnome.org/show_bug.cgi?id=556254
Matthias Clasen [Mon, 6 Jun 2016 01:47:16 +0000 (21:47 -0400)]
Make gtk_tooltip_trigger_tooltip_query work again
This was broken ever since we started looking at the
source device of the event.
https://bugzilla.gnome.org/show_bug.cgi?id=674215
Matthias Clasen [Mon, 6 Jun 2016 00:54:49 +0000 (20:54 -0400)]
inspector: Ellipsize accessible description.
This string can be long, and we don't want to break the ui
Matthias Clasen [Sun, 5 Jun 2016 23:36:36 +0000 (19:36 -0400)]
viewport: Free gadgets in finalize
This is the right place for this.
Matthias Clasen [Sun, 5 Jun 2016 23:36:09 +0000 (19:36 -0400)]
scrolled window: Free gestures and gadgets in finalize
This is the right place for this.
Matthias Clasen [Sun, 5 Jun 2016 23:35:36 +0000 (19:35 -0400)]
range: Free gadgets in finalize
This is the right place for this.
Matthias Clasen [Sun, 5 Jun 2016 23:35:12 +0000 (19:35 -0400)]
notebook: Free gadgets in finalize
This is the right place for this.
Matthias Clasen [Sun, 5 Jun 2016 23:34:30 +0000 (19:34 -0400)]
menu: Free gadgets in finalize
This is the right place to do this.
Matthias Clasen [Sun, 5 Jun 2016 23:33:21 +0000 (19:33 -0400)]
button: Free gadgets and gestures in finalize
This is the right place to free them.
Georges Basile Stavracas Neto [Fri, 3 Jun 2016 01:32:56 +0000 (22:32 -0300)]
testsuite: add tests for scrolledwindow
This patch adds a set of tests for scrolled window
sizing, covering both min- and max-content width and
height.
https://bugzilla.gnome.org/show_bug.cgi?id=742281
Georges Basile Stavracas Neto [Thu, 2 Jun 2016 02:32:35 +0000 (23:32 -0300)]
tests: adapt testscrolledwindow to have max content sizes
This patch adpats the current test to show a popover with
max-content-width and -height properties set.
https://bugzilla.gnome.org/show_bug.cgi?id=742281
Georges Basile Stavracas Neto [Thu, 2 Jun 2016 02:18:37 +0000 (23:18 -0300)]
scrolledwindow: add ::max-content-width and -height properties
The GtkScrolledWindow has support to set the minimum content size (both
width and height) which controls the minimum space allocated, but does
not exposes any way to control the maximum size the content can grow.
After the introduction of GtkPopover, which always uses the minimum
size of it's children widgets, the lack of max-content-width and -height
properties became a concrete use case.
This patch introduces the GtkScrolledWindow::max-content-width and
-height properties. The properties will alter the minimum size of
the scrolled window, making it grow up to the set value. They also
respect the previously set ::min-content-width and -height.
https://bugzilla.gnome.org/show_bug.cgi?id=742281
Руслан Ижбулатов [Sun, 5 Jun 2016 07:37:02 +0000 (07:37 +0000)]
GDK W32: Fix dragging AeroSnap application
The original patch for commit
b420c53773ca5119afb43f0f351cb8f33c2bcaf9
was applied incorrectly, doing the actual snapping in the wrong place.
Move the code.
Matthias Clasen [Fri, 3 Jun 2016 20:30:00 +0000 (16:30 -0400)]
progressbar: Render text with the text css node
This is the same fix that was just applied to GtkScale.
Matthias Clasen [Fri, 3 Jun 2016 14:49:29 +0000 (10:49 -0400)]
scale: Also queue a resize if font changes
As Benjamin pointed out, what AFFECTS_FONT can also affect size,
but the implication is not automatic, so queue a resize manually.
Pavel Grunt [Thu, 2 Jun 2016 13:35:38 +0000 (15:35 +0200)]
gdktypes: Update docs for GDK_GRAB_FAILED
Mention in documentation that it is available since 3.16
https://bugzilla.gnome.org/show_bug.cgi?id=767165
Matthias Clasen [Fri, 3 Jun 2016 04:30:59 +0000 (00:30 -0400)]
scale: Apply css style to text
Use the new functions we have to apply CSS styles to the
value and marks text from their respective subnodes.
Matthias Clasen [Fri, 3 Jun 2016 04:29:05 +0000 (00:29 -0400)]
Add a function to get a font from a css style
Similar in spirit to
gtk_style_context_get (ctx, state, "font", ...)
but avoids the need for a style context.
This will be used to for css-styled text rendering
from css subnodes.
Matthias Clasen [Fri, 3 Jun 2016 04:19:24 +0000 (00:19 -0400)]
Add a function to turn a css style into pango attributes
This is _gtk_style_context_get_pango_attributes, decoupled
from the GtkStyleContext. This will be used to drive css-styled
text rendering from css subnodes of widgets, e.g. for the value
in GtkScale.
Timm Bäder [Thu, 2 Jun 2016 19:52:11 +0000 (21:52 +0200)]
widget: Avoid a deprecation warning
Matthias Clasen [Wed, 1 Jun 2016 03:33:54 +0000 (23:33 -0400)]
Show a scroll cursor when appropriate
When doing two-finger scrolling or click scrolling using a
trackpoint, show the all-scroll cursor to indicate what is
going on.
https://bugzilla.gnome.org/show_bug.cgi?id=753202
Matthias Clasen [Wed, 1 Jun 2016 03:14:30 +0000 (23:14 -0400)]
wayland: Provide information about scroll devices
The Wayland protocol does not share XI2's wealth of information
about individual devices, but it does provide discriminating
information about the source for scroll events. Pass this on to
the application by creating separate slave devices for these,
and setting them as source device on the scroll events.
These devices can be discriminated by their input-source property:
wheel - GDK_SOURCE_MOUSE
finger - GDK_SOURCE_TOUCHPAD
continuous - GDK_SOURCE_TRACKPOINT
https://bugzilla.gnome.org/show_bug.cgi?id=767093
fix up
Matthias Clasen [Wed, 1 Jun 2016 18:18:46 +0000 (14:18 -0400)]
a11y tests: Update expected output
These changes were caused by the introduction of GtkStackAccessible.
Matthias Clasen [Wed, 1 Jun 2016 17:12:19 +0000 (13:12 -0400)]
button css node test: Update for switch style changes
We no longer add the redundant .slider style class in GtkSwitch.
Update expected results to reflect that.
Matthias Clasen [Wed, 1 Jun 2016 17:11:27 +0000 (13:11 -0400)]
css node tests: Update expected results
We were not propagating direction changes in some places,
evidently. Now we do.
Matthias Clasen [Wed, 1 Jun 2016 15:52:20 +0000 (11:52 -0400)]
popover menu: Improved labeled separators
Embed the label in the middle of the separators instead of
putting it above the separator.
https://bugzilla.gnome.org/show_bug.cgi?id=767108
Bastien Nocera [Wed, 1 Jun 2016 13:58:22 +0000 (15:58 +0200)]
Separators not correctly placed
What it should look like:
Bold
----
/Size/
x 0.5
x 1.0
What it looks like:
Bold
/Size/
----
x 0.5
x 1.0
https://bugzilla.gnome.org/show_bug.cgi?id=767108
Matthias Clasen [Wed, 1 Jun 2016 11:01:37 +0000 (07:01 -0400)]
scrolled window: Remove trackpoint heuristics
This is now done in GDK, so we can just use the input type here.
https://bugzilla.gnome.org/show_bug.cgi?id=767100
Matthias Clasen [Wed, 1 Jun 2016 10:58:43 +0000 (06:58 -0400)]
x11: Mark trackpoints as GDK_SOURCE_TRACKPOINT
This uses the same heuristics that are currently used in
GtkScrolledWindow.
https://bugzilla.gnome.org/show_bug.cgi?id=767100
Matthias Clasen [Wed, 1 Jun 2016 10:57:46 +0000 (06:57 -0400)]
gdk: Add GDK_SOURCE_TRACKPOINT
Having this as an input source type will let us do the heuristics
in the GDK backends.
https://bugzilla.gnome.org/show_bug.cgi?id=767100
Matthias Clasen [Wed, 1 Jun 2016 11:00:18 +0000 (07:00 -0400)]
Avoid a deprecation warning
Olivier Fourdan [Tue, 31 May 2016 13:25:52 +0000 (15:25 +0200)]
headerbar: do not show buttons for modals/transients
GtkHeadeBar checks the window type hint to determine if the regular
buttons such as menu, maximize or iconify should be visible in the
header bar.
However, an application may very well use a "normal" toplevel window and
set it transient and modal afterwards. In such a case, the iconify
button would remain visible, and the user can hide the window, but being
a modal, the parent window would remain insensitive.
Check for the window type, modality and transient relationship to decide
whether or not the regular toplevel buttons should be visible in the
header bar.
https://bugzilla.gnome.org/show_bug.cgi?id=767052
Matthias Clasen [Wed, 1 Jun 2016 02:05:58 +0000 (22:05 -0400)]
wayland: Better debug info for scroll axes
Print human readable names for axes and axis sources.
Matthias Clasen [Tue, 31 May 2016 20:33:18 +0000 (16:33 -0400)]
docs: Add a release note about GtkSizeGroup::ignore-hidden
Matthias Clasen [Tue, 31 May 2016 20:32:20 +0000 (16:32 -0400)]
GtkShortcutsSection: avoid deprecation warnings
We could just as well remove these calls here, since they
have no effect.
Matthias Clasen [Tue, 31 May 2016 20:19:52 +0000 (16:19 -0400)]
Document GtkSizeGroup::ignore-hidden as broken
...and deprecate it, recommending GtkStack as an alternative.
Lapo Calamandrei [Tue, 31 May 2016 18:58:35 +0000 (20:58 +0200)]
Adwaita: ensure menuitem labels are not overridden
see https://bugzilla.gnome.org/show_bug.cgi?id=767058
Timm Bäder [Sun, 29 May 2016 16:34:35 +0000 (18:34 +0200)]
entry: Fix undershoot position wrt entry icons
Draw them inside of the icons, which is where the text scrolls.
Matthias Clasen [Tue, 31 May 2016 00:24:13 +0000 (20:24 -0400)]
README: Refer to release notes online
We don't want to maintain this information in two places,
so just link to the online documentation here.
Matthias Clasen [Tue, 31 May 2016 00:21:48 +0000 (20:21 -0400)]
docs: Fix a duplicate ID
This was causing navigation in the online docs to be confused.
Matthias Clasen [Mon, 30 May 2016 20:14:36 +0000 (16:14 -0400)]
Add a warning for a broken situation
When we emit ::draw, the widget should not have alloc_needed set
anymore. If this happens, it indicates a broken situation. Add a
warning to help tracking down why this might occur.
See https://bugzilla.gnome.org/show_bug.cgi?id=765410
Matthias Clasen [Mon, 30 May 2016 20:07:52 +0000 (16:07 -0400)]
gtk3-demo: Fix some css warnings
Update the font: syntax to follow css.
Timm Bäder [Mon, 30 May 2016 18:40:43 +0000 (20:40 +0200)]
build: add GtkStack accessible private header at the right place
Daniel Mustieles [Mon, 30 May 2016 17:16:21 +0000 (19:16 +0200)]
Updated Spanish translation
Timm Bäder [Sun, 22 May 2016 06:24:46 +0000 (08:24 +0200)]
range: Properly indent closing brace
Make sure it's obvious what if block it belongs to.
Timm Bäder [Sun, 29 May 2016 11:51:02 +0000 (13:51 +0200)]
Add GtkStackAccessible
Show only the currently visible child to a11y.
Timm Bäder [Mon, 30 May 2016 06:59:46 +0000 (08:59 +0200)]
tests/scrolling-performance: Define MyTextView
The type is used in widget-factory.ui, so add a dummy definition here to
keep the test working.
Cédric Valmary [Mon, 30 May 2016 16:59:28 +0000 (16:59 +0000)]
Updated Occitan translation
Cédric Valmary [Mon, 30 May 2016 16:58:07 +0000 (16:58 +0000)]
Updated Occitan translation
Lapo Calamandrei [Mon, 30 May 2016 12:20:33 +0000 (14:20 +0200)]
Adwaita: explicitelly set label caret-color to currentColor
since it doesn't always inherit 'color' color as it should.
Lapo Calamandrei [Mon, 30 May 2016 11:56:23 +0000 (13:56 +0200)]
Adwaita: make selection on infobars visible
see https://bugzilla.gnome.org/show_bug.cgi?id=745622
Theppitak Karoonboonyanan [Mon, 30 May 2016 05:45:19 +0000 (12:45 +0700)]
Updated Thai translation
Jordi Mas [Sat, 28 May 2016 05:27:51 +0000 (07:27 +0200)]
Fixes to Catalan translation
Jordi Mas [Sat, 28 May 2016 05:21:39 +0000 (07:21 +0200)]
Update Catalan translation
Lapo Calamandrei [Fri, 27 May 2016 09:34:47 +0000 (11:34 +0200)]
Adwaita: remove textview border
see https://bugzilla.gnome.org/show_bug.cgi?id=764203
Theppitak Karoonboonyanan [Fri, 27 May 2016 08:49:58 +0000 (15:49 +0700)]
Updated Thai translation
Rico Tzschichholz [Fri, 27 May 2016 07:27:53 +0000 (09:27 +0200)]
x11: Replace RROutput with XID as used in GdkX11Monitor
This avoids an unconditional use of XRandr symbol.
Thomas Lange [Wed, 25 May 2016 18:16:04 +0000 (20:16 +0200)]
placesview: Do not mark icon name as translatable
https://bugzilla.gnome.org/show_bug.cgi?id=766878
Matthias Clasen [Thu, 26 May 2016 17:57:20 +0000 (13:57 -0400)]
3.21.2
Matthias Clasen [Thu, 26 May 2016 17:56:59 +0000 (13:56 -0400)]
Updates
Matthias Clasen [Thu, 26 May 2016 17:21:50 +0000 (13:21 -0400)]
Teach gtk-builder-tool to leave GtkDialog::border-width alone
This is one of the properties that need to be explicitly set.
Tiago Santos [Thu, 26 May 2016 13:44:51 +0000 (13:44 +0000)]
Updated Portuguese translation
Emmanuele Bassi [Thu, 26 May 2016 11:45:51 +0000 (12:45 +0100)]
Silence a compiler warning
Initialize the `nearest` variable.
Руслан Ижбулатов [Mon, 9 May 2016 12:48:07 +0000 (12:48 +0000)]
GtkFileChooser: don't override already opened folder
When filechooer is re-used (instead of being created and destroyed
every time it's needed), it might happen that the directory the
application wishes to initially show is the same directory that
was shown last time the filechooser was used. In that case, make sure
filechooser knows that it does not need to do its default "select $pwd
or $home" routine.
https://bugzilla.gnome.org/show_bug.cgi?id=766122
Matthias Clasen [Wed, 25 May 2016 19:56:04 +0000 (15:56 -0400)]
Mention CSS font property in the release notes
Friedrich Herbst [Wed, 25 May 2016 08:36:09 +0000 (08:36 +0000)]
Updated German translation
Matthias Clasen [Wed, 25 May 2016 04:55:11 +0000 (00:55 -0400)]
Move release notes to online docs
This will let us expand the information e.g. with code examples,
and can serve as starting material for a future 3->4 migration
guide.
Matthias Clasen [Wed, 25 May 2016 00:55:16 +0000 (20:55 -0400)]
Update migration guide a bit
Resize grips are no more.
Matthias Clasen [Wed, 25 May 2016 00:51:55 +0000 (20:51 -0400)]
Fix a duplicate word in the docs
Benjamin Otte [Tue, 24 May 2016 23:16:52 +0000 (01:16 +0200)]
window: Unfreeze window on unmap
Make sure to keep parity with the number of times we froze the window
when we unmap it.
Otherwise it will permanently stay frozen after being remapped.
https://bugzilla.gnome.org/show_bug.cgi?id=766643
https://bugzilla.mozilla.org/show_bug.cgi?id=
1225044
Bastian Ilsø [Wed, 1 Apr 2015 20:46:46 +0000 (22:46 +0200)]
gtktextview: document how to get line space
adds a paragraph to gtk_text_view_get_pixels_below_lines(),
describing how it can be used together with
gtk_text_view_get_pixels_above_lines() to get the total
amount of line spacing between two paragraphs.
https://bugzilla.gnome.org/show_bug.cgi?id=747206
Matthias Clasen [Tue, 24 May 2016 00:40:03 +0000 (20:40 -0400)]
Add a deprecation note
Mark GtkWidget:style property as deprecated in the docs.
Matthias Clasen [Mon, 23 May 2016 23:25:41 +0000 (19:25 -0400)]
Improve CSS docs a bit
Among other things, explain the relationship of background-color
and background-image.
Matthias Clasen [Mon, 23 May 2016 23:24:07 +0000 (19:24 -0400)]
Trivial typo fix
Matthias Clasen [Mon, 23 May 2016 18:17:13 +0000 (14:17 -0400)]
Remove an unused variable
Matthias Clasen [Mon, 23 May 2016 18:14:32 +0000 (14:14 -0400)]
infobar: Update documentation
Remove explicit reference to color from the
gtk_info_bar_set_message_type() docs.
https://bugzilla.gnome.org/show_bug.cgi?id=759037
Kjartan Maraas [Mon, 23 May 2016 16:56:30 +0000 (18:56 +0200)]
Updated Norwegian bokmål translation.
Emmanuele Bassi [Mon, 23 May 2016 07:34:39 +0000 (08:34 +0100)]
gdk: Provide safe fallback for creating GL contexts
If the backend does not override GdkWindowClass.create_gl_context()
then we should provide a fallback that gives an error, instead of
crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=766782
Emmanuele Bassi [Mon, 23 May 2016 07:31:47 +0000 (08:31 +0100)]
gl: Add a realize() fallback
Calling gdk_gl_context_realize() should always result in a valid result,
so we need to provide a default implementation, to avoid a call to a
NULL function pointer.
Anders Jonsson [Sat, 21 May 2016 21:39:34 +0000 (21:39 +0000)]
Updated Swedish translation
Carlos Garnacho [Sat, 21 May 2016 17:43:15 +0000 (19:43 +0200)]
popover: set priv->window before setting doing add_popover() on it
If the popover's relative-to widget is unparented/reparented, we end
up unparenting/reparenting the popover as well. In that case, at the
moment of reparenting, the widget might have been visible (and is
thus mapped again), but priv->window hasn't been set yet.
We must first set priv->window, and then call gtk_window_add_popover(),
that way gtk_popover_map() has its prerequisites straight.
https://bugzilla.gnome.org/show_bug.cgi?id=766323
Khaled Hosny [Sat, 21 May 2016 13:54:19 +0000 (15:54 +0200)]
Typo
Khaled Hosny [Sat, 21 May 2016 05:40:09 +0000 (07:40 +0200)]
Update Arabic translation
Florian Müllner [Fri, 20 May 2016 22:07:10 +0000 (00:07 +0200)]
stack: Only map children when necessary
gtk_widget_set_parent() will map the widget if the parent is mapped
and the widget is both visible and child-visible. As we currently
only set the child visibility after adding the child, we immediately
map all children that are added to a mapped stack, even when they
are not actually shown. Avoid this by setting the child visibility
before adding the child, so widgets are only mapped when shown.
https://bugzilla.gnome.org/show_bug.cgi?id=766737
Lapo Calamandrei [Fri, 20 May 2016 13:39:08 +0000 (15:39 +0200)]
Adwaita: add vertical margins to switches on a headerbar
See https://bugzilla.gnome.org/show_bug.cgi?id=766642
Lapo Calamandrei [Fri, 20 May 2016 13:28:58 +0000 (15:28 +0200)]
Adwaita: shave 1px from the switch
make the switch height and width 1px smaller.
Ondrej Holy [Mon, 2 May 2016 10:55:56 +0000 (12:55 +0200)]
Improve external drives detection
Use g_drive_is_removable for external drives detection. Current heuristic
fails in some cases (e.g. when removable drive is attached before login),
see Bug 765457.
Bump GLib version accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=765924
Ignacio Casal Quinteiro [Fri, 20 May 2016 07:08:08 +0000 (09:08 +0200)]
gtktextview: fix < public > comment
This was causing problems with the gtk# scanner
Matthias Clasen [Thu, 19 May 2016 20:59:10 +0000 (16:59 -0400)]
treeview: Fix a rubberbanding-related crash
When starting a rubberband selection from an empty area, we could run
into crashes if the selection moves over the rows and then back out
to unpopulated area. Handle this case without crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=766336